Add experimentalIdentityAndAuth flag
#857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
add-experimentalIdentityAndAuth-flag
branch
3 times, most recently
from
616e3e1 to
afeb923
Compare
milesziemer
reviewed
Aug 9, 2023
...main/java/software/amazon/smithy/typescript/codegen/integration/AddHttpApiKeyAuthPlugin.java
Outdated
Show resolved
Hide resolved
syall
force-pushed
the
add-experimentalIdentityAndAuth-flag
branch
2 times, most recently
from
68409c6 to
649833b
Compare
Add the experimental feature flag for identity and auth `experimentalIdentityAndAuth` in `TypeScriptSettings`. - For `AddHttpApiKeyAuthPlugin`, make the current behavior the control branch for `experimentalIdentityAndAuth`. - Add a test projection in `smithy-typescript-codegen-test` for `experimentalIdentityAndAuth`. Also, add a section in `CONTRIBUTING.md` about experimental features in `smithy-typescript`.
syall
force-pushed
the
add-experimentalIdentityAndAuth-flag
branch
from
649833b to
82f8ab2
Compare
trivikr
approved these changes
Aug 9, 2023
milesziemer
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A.
Description of changes:
Dependent on #856.
Add the experimental feature flag for identity and auth
experimentalIdentityAndAuthinTypeScriptSettings.AddHttpApiKeyAuthPlugin, make the current behavior the control branch forexperimentalIdentityAndAuth.smithy-typescript-codegen-testforexperimentalIdentityAndAuth.Also, add a section in
CONTRIBUTING.mdabout experimental features insmithy-typescript.If one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.