chore(codegen): match lib and target declarations #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lib` declarations targeting standards newer than the `target` are useful when one polyfills missing features. `lib` declarations targeting _older_ standards are constraining in a strange way: we emit code relying on newer features, but types prevent us from using them Since were are already emitting `es2018` code, we can target that standard for the types as well. This is a spin-off of @eduardomourar's smithy-lang#667 Co-authored-by: Eduardo Rodrigues <[email protected]>
srchase
approved these changes
Feb 3, 2023
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
`lib` declarations targeting standards newer than the `target` are useful when one polyfills missing features. `lib` declarations targeting _older_ standards are constraining in a strange way: we emit code relying on newer features, but types prevent us from using them Since were are already emitting `es2018` code, we can target that standard for the types as well. This is a spin-off of @eduardomourar's smithy-lang#667 Co-authored-by: Eduardo Rodrigues <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libdeclarations targeting standards newer than thetargetare useful when one polyfills missing features.libdeclarations targeting older standards are constraining in a strange way: we emit code relying on newer features, but types prevent us from using themSince were are already emitting
es2018code, we can target that standard for the types as well.This is a spin-off of @eduardomourar's #667
Co-authored-by: Eduardo Rodrigues [email protected]
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.