Fix codegen windows #661
Merged
Fix codegen windows #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened this as a draft because it feels a little flimsy. There's a few places where we have to do the same string manipulation, that I think could be refactored, but I wasn't sure exactly how to do it. |
srchase
approved these changes
Jan 3, 2023
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
* Fix codegen on Windows * Add Windows and Mac OS CI * Fix failing CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#568
Description of changes:
The use of
Paths.getwhen creating an import/export path, ie.import { Foo } from ./path, caused tests to fail on Windows because the tests expect unix-like paths. For portability and consistency, the places where import/export paths are created inSymbolVisitorandImportDeclarationswere refactored to always create unix-like path separators regardless of OS.Additionally, CI was added for Windows (and MacOS since it wasn't there already).
Testing details:
./gradlew clean buildsuccessfully on Windows and MacBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.