Use DirectedCodegen #585
Merged
Use DirectedCodegen #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
approved these changes
Aug 31, 2022
gosar
force-pushed
the
directed-merge
branch
2 times, most recently
from
0ab146e to
79b7ede
Compare
Migrate the code generator to use Smithy's new and recommended DirectedCodegen.
gosar
force-pushed
the
directed-merge
branch
from
79b7ede to
2159d71
Compare
gosar
added a commit
to gosar/aws-sdk-js-v3
that referenced
this pull request
Sep 16, 2022
Based on smithy-typescript changes in smithy-lang/smithy-typescript#585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating the code generator to use Smithy's new and recommended DirectedCodegen.
These changes were initially reviewed in #548 to merge the changes in
directed-codegenbranch. It was merged into a branch, since the dependent Smithy release wasn't complete then. Now that is done, merging thedirected-codegenbranch tomain.I basically merged
directed-codegenintomain, resolved some very minor conflicts, and new commit to add the new EndpointV2 logic to DirectedCodegen instead of the deleted CodegenVisitor. And then I squashed all commits into a single one and force pushed to gosar:directed-merge, the branch for this PR.I retested with
yarn generate-clients && yarn test:protocols && yarn generate-clients -s && yarn install && yarn test:server-protocolsand there are no diffs to generated clients, except for 1 client (identitystore) where there is rearranging of couple of exception classes only - aws/aws-sdk-js-v3#3963.Note to reviewer, since @kuhe's approval on 8/31 (which was on commit d14731f), here are the changes after rebasing/squashing - https://github.com/awslabs/smithy-typescript/compare/d14731f006c8d73881cab2bc947113e5918bf997..2159d71300e4922c59c468cdb5ccb71ae055fe1f
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.