feat(codegen): remove namespaces that only contain logfilters #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
approved these changes
Jul 25, 2022
AllanZhengYP
approved these changes
Jul 26, 2022
gosar
added a commit
to gosar/smithy-typescript
that referenced
this pull request
Aug 31, 2022
This was removed in directed-codegen branch as it was unused, but since then a new PR smithy-lang#574 in main is using it, so adding it back.
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
…-lang#574) * feat(codegen): remove namespaces that only contain logfilters * feat(namespaces): remove unused import in test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model Namespaces
Problem: model namespaces containing only a filterSensitiveLog function are generated alongside most model interfaces. This is distracting to readers of the model file, and worse, creates an interruption when users use VSCode’s go-to-definition functionality on model interfaces that have an identical name with these namespaces.
Solution: remove these namespaces and generate the filter functions with unique names.