Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error shapes do not explicitly need to reference MetadataBearer #545

Merged
merged 1 commit into from
May 18, 2022

Conversation

gosar
Copy link
Contributor

@gosar gosar commented May 18, 2022

This is causing unnecessary imports in generated clients like https://github.com/aws/aws-sdk-js-v3/blob/6d232d050605a9a335771562ca6d08e31ccbcdaf/clients/client-accessanalyzer/src/models/models_0.ts#L3

Corresponding update to generated AWS clients aws/aws-sdk-js-v3#3621

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I probably missed it in previous exception-related change.

@gosar gosar merged commit cde5684 into smithy-lang:main May 18, 2022
@gosar gosar deleted the metadataBearer branch May 18, 2022 23:40
@gosar gosar mentioned this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants