Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codegen): configurable package manager #476

Merged

Conversation

adamthom-amzn
Copy link
Contributor

@adamthom-amzn adamthom-amzn commented Dec 15, 2021

Issue #, if available:

Resolves #347

Description of changes:
Generated packages all use yarn in their package.json, which is not always
available. This adds a configuration to the code generator called
packageManager, which can be set to yarn or npm, or omitted for the default,
which remains yarn for backwards compatibility.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Generated packages all use yarn in their package.json, which is not always
available. This adds a configuration to the code generator called
packageManager, which can be set to yarn or npm, or omitted for the default,
which remains yarn for backwards compatibility.
@adamthom-amzn adamthom-amzn requested a review from a team as a code owner December 15, 2021 22:32
Copy link
Contributor

@JordonPhillips JordonPhillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@adamthom-amzn adamthom-amzn merged commit d263078 into smithy-lang:main Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow build tool to be configurable
3 participants