Switch to re2-wasm #467
Merged
Switch to re2-wasm #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamthom-amzn
requested review from
gosar,
JordonPhillips and
a team
as code owners
JordonPhillips
approved these changes
Nov 23, 2021
|
yarn.lock deleted on purpose or by mistake? |
|
On purpose - the root yarn.lock is the one that matters, right? The ones in these workspaces didn’t regenerate when I ran yarn install.
On Nov 23, 2021, at 8:05 AM, Trivikram Kamat ***@***.***> wrote:
yarn.lock deleted on purpose or by mistake?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#467 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOX4W4PGJVHBZTZIQPWIMR3UNO3S3ANCNFSM5INFDK6A>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Yes. Move removal of yarn.lock files to a different |
gosar
approved these changes
Nov 23, 2021
re2 uses a native module that has a normal dependency on node-gyp, which bloats the installed size of a service and requires special care when packaging. re2-wasm has no dependencies, and while it is not officially supported, it is used by grpc-node's grpc-js-xds package.
adamthom-amzn
force-pushed
the
re2-wasm
branch
from
3390333 to
bcc8b22
Compare
done |
trivikr
approved these changes
Nov 29, 2021
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
re2 uses a native module that has a normal dependency on node-gyp, which bloats the installed size of a service and requires special care when packaging. re2-wasm has no dependencies, and while it is not officially supported, it is used by grpc-node's grpc-js-xds package.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
re2 uses a native module that has a normal dependency on node-gyp, which
bloats the installed size of a service and requires special care when
packaging.
re2-wasm has no dependencies, and while it is not officially supported, it is
used by grpc-node's grpc-js-xds package.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.