Better handling of Accept headers #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept values can have wildcards, and multiple types can be specified in the header. Use a helper function to handle all the possible permutations specified in https://datatracker.ietf.org/doc/html/rfc7231#section-5.3.2
JordonPhillips
approved these changes
Sep 27, 2021
trivikr
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently, we do an exact-match of the Accept header (if present) against the document media type for the protocol. Accept headers can be much more complicated than a single media type, so we must parse it to be sure that the client cannot handle our preferred response type before sending a 406 response.
I tested this by regenerating and re-running the server protocol tests against the tip of the SDK's main. They pass.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.