Parse timestamps strictly #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timestamp formats are modeled, and instead of relying on the JavaScript Date constructor's undefined behavior to support all three styles of timestamp, we use a specific strict parsing method based on the modeled type to ensure that we are only accepting timestamps in the correct format. DocumentMemberDeserVisitor did not have a reference to the member being deserialized, so it could not discover traits that were applied to the member (such as @timestampFormat). It also needed to know whether epoch timestamps are allowed to be strings, which is protocol-specific.
AllanZhengYP
approved these changes
Sep 1, 2021
JordonPhillips
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Timestamp formats are modeled, and instead of relying on the JavaScript Date
constructor's undefined behavior to support all three styles of timestamp,
we use a specific strict parsing method based on the modeled type to ensure
that we are only accepting timestamps in the correct format.
DocumentMemberDeserVisitordid not have a reference to the member beingdeserialized, so it could not discover traits that were applied to the member
(such as
@timestampFormat). It also needed to know whether epochtimestamps are allowed to be strings, which is protocol-specific.
This relies on aws/aws-sdk-js-v3#2737 and there will be a follow-up PR for SDK-specific generation changes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.