Parse request and response payloads strictly #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
approved these changes
Aug 27, 2021
adamthom-amzn
force-pushed
the
strict-body-parsing
branch
from
ffcd7a6 to
e93a294
Compare
If a restJson1 protocol request or response is a structure (as opposed to being a bound payload), it must be a non-null JSON object. If it's a payload bound to a union or structure, it must be a JSON object. Previously, body parsing would take any output from JSON.parse and attempt to pull members off of the result by name, even if JSON.parse returned a non-object type.
adamthom-amzn
force-pushed
the
strict-body-parsing
branch
from
e93a294 to
4a2531e
Compare
AllanZhengYP
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
If a restJson1 protocol request or response is a structure (as opposed to being
a bound payload), it must be a non-null JSON object. If it's a payload bound to
a union or structure, it must be a JSON object. Previously, body parsing would
take any output from JSON.parse and attempt to pull members off of the result
by name, even if JSON.parse returned a non-object type.
This depends on aws/aws-sdk-js-v3#2713 - client changes are demo'd on my fork here: adamthom-amzn/aws-sdk-js-v3#22 and protocol tests pass.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.