Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(credential-provider-imds): add flag for blocking imds v1 fallback behavior #1059

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 2, 2023

this is an AWS-specific feature but the code package is housed here in Smithy-TS at least for the time being.

this PR adds 3 locations from which to shut off the IMDS v1 fallback behavior:

  • runtime code initialization of the IMDS or upstream chained credential providers
  • AWS config file profile setting
  • process environment variable

@kuhe kuhe requested review from a team as code owners November 2, 2023 15:53
@kuhe kuhe force-pushed the feat/imds-v1-fallback branch from c152a40 to 30aaf1c Compare November 2, 2023 16:39
@kuhe
Copy link
Contributor Author

kuhe commented Nov 2, 2023

formatting error is false positive, turbo cache issue?

@kuhe kuhe merged commit 4693031 into smithy-lang:main Nov 2, 2023
@kuhe kuhe deleted the feat/imds-v1-fallback branch November 2, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants