Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Rename environment variable used to enable polling #101

Closed
mikeharder opened this issue May 20, 2016 · 6 comments
Closed

Rename environment variable used to enable polling #101

mikeharder opened this issue May 20, 2016 · 6 comments

Comments

@mikeharder
Copy link
Contributor

mikeharder commented May 20, 2016

Both dotnet-watch and MVC use environment variables to enable polling. Currently, dotnet-watch uses USE_POLLING_FILE_WATCHER, while MVC uses ASPNETCORE_POLL_FOR_FILE_CHANGES. To simplify things for customers, including the Dockerfile generated by Docker for VS Tooling, we would like to use the same variable for both dotnet-watch and MVC, and name it accordingly.

Related: aspnet/Mvc#4696

@muratg
Copy link

muratg commented May 25, 2016

@Eilon Can we agree on a name? @victorhurdugaci will do the change both here and on aspnet/Mvc#4696

cc @pranavkm

@mikeharder
Copy link
Contributor Author

Existing names:

USE_POLLING_FILE_WATCHER (dotnet-watch)
ASPNETCORE_POLL_FOR_FILE_CHANGES (mvc)

Proposals for unified name:

WATCHER_POLL_FOR_FILE_CHANGES
WATCHER_USE_POLLING
NETCORE_POLL_FOR_FILE_CHANGES

@muratg
Copy link

muratg commented May 25, 2016

DOTNET_USE_POLLING_FILE_WATCHER?

@Eilon
Copy link
Member

Eilon commented May 26, 2016

Yeah I dig that name.

@Eilon
Copy link
Member

Eilon commented May 26, 2016

That is, the name that @muratg suggested.

@muratg
Copy link

muratg commented May 26, 2016

@victorhurdugaci please update it both here and in MVC.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants