Skip to content
This repository was archived by the owner on Dec 18, 2017. It is now read-only.

Unresolved project path from lock file cause NullRef in ApplicationHostContext #2729

Closed
troydai opened this issue Sep 17, 2015 · 5 comments
Closed

Unresolved project path from lock file cause NullRef in ApplicationHostContext #2729

troydai opened this issue Sep 17, 2015 · 5 comments
Assignees
@troydai
Labels
3 - Done bug
Milestone
1.0.0-beta8

Comments

@troydai
Copy link
Contributor

troydai commented Sep 17, 2015

When a relative project path from lock file can't locate the project reference, the ProjectDependencyProvider returns a null. It then cause a NullRef later in ApplicaitonHostContext initialization.

Instead it should be marked as unresolved.

https://github.com/aspnet/dnx/blob/dev/src/Microsoft.Dnx.Runtime/DependencyManagement/ProjectDependencyProvider.cs#L22

https://github.com/aspnet/dnx/blob/dev/src/Microsoft.Dnx.Runtime/ApplicationHostContext.cs#L199

https://github.com/aspnet/dnx/blob/dev/src/Microsoft.Dnx.Runtime/ApplicationHostContext.cs#L63
@troydai troydai added the bug label Sep 17, 2015
@troydai
Copy link
Contributor Author

troydai commented Sep 17, 2015

@muratg @glennc for triage
/cc @davidfowl

@troydai
Copy link
Contributor Author

troydai commented Sep 17, 2015

/cc @rynowak

@troydai troydai self-assigned this Sep 17, 2015
@troydai
Copy link
Contributor Author

troydai commented Sep 17, 2015

@muratg I'll assign this to me for now.

@muratg muratg added this to the 1.0.0-beta8 milestone Sep 17, 2015
@troydai
Copy link
Contributor Author

troydai commented Sep 17, 2015

/cc @victorhurdugaci who hits this issue today as well.

@troydai troydai mentioned this issue Sep 18, 2015
Merged
@troydai
Copy link
Contributor Author

troydai commented Sep 19, 2015

Fixed in 6944973

@troydai troydai closed this as completed Sep 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@troydai troydai

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-beta8
Development

No branches or pull requests
2 participants
@troydai @muratg