DNU should allow absence of "versions" property in v3 index.json

[ChengTian]

That means we also consider unlisted packages during restore. It can also fix the exception thrown by dnu restore when restoring package like https://az320820.vo.msecnd.net/v3-flatcontainer/classlibrary1/index.json

@davidfowl agrees that this can be assigned to me.

[pranavkm]

cc @yishaigalatzer Might be something that needs to be ported to nuget.

[yishaigalatzer]

This seems wrong. The plan is to fix the server, although we can revisit the discussion worth a short f2f tomorrow

[ChengTian]

@yishaigalatzer , to fix at server side, do you want to return index.json that always contain versions property, even it is empty?

The current problem is that if all versions of a package are unlisted, we get index.json like

{
  "unlistedVersions": [
    "1.0.0"
  ]
}

The absence of versions property makes dnu think it is an invalid response.

/cc @davidfowl @lodejard

[ChengTian]

Talked to @davidfowl and we want to leave the current implementation for now. I filed an issue for fixing at server side: NuGet/NuGetGallery#2617

[ChengTian]

Need a discussion to decide whether we still want this change. Putting to backlog.

[lodejard]

Seems reasonable to treat missing property the same as an empty array

[ChengTian]

@lodejard , makes sense, I have a PR for it here: #2459. Please help to review.

[ChengTian]

The work at server side is tracked at NuGet/NuGetGallery#2617 and NuGet team is deploying the changes now. The fix at DNX side is merged. Closing.