You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 18, 2017. It is now read-only.
When a vanilla DNX project is created, a global.json file containing the sdk.version property is generated. When a Service Fabric DNX project is created, an empty global.json file is generated (see #1654).
If global.json is missing the sdk.version property, command-line builds fail. This is because the GetRuntimeToolingPath task ($/DevDiv/Offcycle/WPT/WebToolsExtensions/Main/src/ProjectK/MSBuildTasks/GetRuntimeToolingPath) throws an exception if sdk.version is missing from global.json. This task is invoked by C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets.
There are two approaches we could take to fix this:
Make sure global.json is generated with an sdk.version property (it should probably be beta4 for now).
Modify the build targets to use a default value (latest?) if the sdk.version property does not exist.
The issue if we only take the second approach is that Service Fabric doesn't currently support latest (beta5). So if we generate an empty global.json, and the msbuild targets default to latest, it will break Service Fabric customers. So ideally, we would implement both approaches.
The text was updated successfully, but these errors were encountered:
When a vanilla DNX project is created, a
global.json
file containing thesdk.version
property is generated. When a Service Fabric DNX project is created, an emptyglobal.json
file is generated (see #1654).If
global.json
is missing thesdk.version
property, command-line builds fail. This is because theGetRuntimeToolingPath
task ($/DevDiv/Offcycle/WPT/WebToolsExtensions/Main/src/ProjectK/MSBuildTasks/GetRuntimeToolingPath
) throws an exception ifsdk.version
is missing fromglobal.json
. This task is invoked byC:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets
.There are two approaches we could take to fix this:
global.json
is generated with ansdk.version
property (it should probably bebeta4
for now).latest
?) if thesdk.version
property does not exist.The issue if we only take the second approach is that Service Fabric doesn't currently support
latest
(beta5). So if we generate an emptyglobal.json
, and the msbuild targets default tolatest
, it will break Service Fabric customers. So ideally, we would implement both approaches.The text was updated successfully, but these errors were encountered: