Skip to content
This repository was archived by the owner on Dec 18, 2017. It is now read-only.

Need a more descriptive message when an incorrect file globbing pattern is entered #1548

Closed
Praburaj opened this issue Mar 30, 2015 · 5 comments
Assignees
Milestone

Comments

@Praburaj
Copy link
Contributor

For example if I accidentally put a * in a globbing pattern that does not allow * e.g:

"compileFiles": [ "*.cs" ],

All we show in the error is this without any line number information, or pointers on what's wrong etc. We should print out a more descriptive error with some information on what exactly is wrong.

image

Expected: compileFile cannot contain wildcard patterns.

@troydai

@Praburaj Praburaj added the bug label Mar 30, 2015
@troydai
Copy link
Contributor

troydai commented Mar 30, 2015

We may exam the 'literal' patterns more carefully while parsing project.json.

https://github.com/aspnet/dnx/blob/dev/src/Microsoft.Framework.Runtime.Hosting/PatternGroup.cs#L80

@davidfowl
Copy link
Member

/cc @troydai Did this ever get fixed?

@troydai
Copy link
Contributor

troydai commented Jul 6, 2015

No, we didn't take action. The error is expected. We can have a better error message through.

@troydai
Copy link
Contributor

troydai commented Jul 6, 2015

/cc @muratg beta6?

@troydai
Copy link
Contributor

troydai commented Jul 23, 2015

Fixed in a486da1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants