From 153bebaf42943512297ae6065a87b8fd181b8746 Mon Sep 17 00:00:00 2001 From: David Fowler Date: Tue, 17 Jun 2014 23:13:54 -0700 Subject: [PATCH] Remove name from project.json - It's always inferred from the folder name. #198 --- src/Microsoft.Framework.Runtime/Project.cs | 13 ++++--------- .../ProjectFacts.cs | 14 ++------------ 2 files changed, 6 insertions(+), 21 deletions(-) diff --git a/src/Microsoft.Framework.Runtime/Project.cs b/src/Microsoft.Framework.Runtime/Project.cs index ddaf650f5..e2fd16396 100644 --- a/src/Microsoft.Framework.Runtime/Project.cs +++ b/src/Microsoft.Framework.Runtime/Project.cs @@ -158,14 +158,14 @@ public static bool TryGetProject(string path, out Project project) var json = File.ReadAllText(projectPath); // Assume the directory name is the project name if none was specified - var fallbackProjectName = GetDirectoryName(path); + var projectName = GetDirectoryName(path); - project = GetProject(json, fallbackProjectName, projectPath); + project = GetProject(json, projectName, projectPath); return true; } - public static Project GetProject(string json, string fallbackProjectName, string projectPath) + public static Project GetProject(string json, string projectName, string projectPath) { var project = new Project(); @@ -174,13 +174,8 @@ public static Project GetProject(string json, string fallbackProjectName, string // Metadata properties var version = rawProject["version"]; var authors = rawProject["authors"]; - project.Name = GetValue(rawProject, "name"); - - if (string.IsNullOrEmpty(project.Name)) - { - project.Name = fallbackProjectName; - } + project.Name = projectName; project.Version = version == null ? new SemanticVersion("1.0.0") : new SemanticVersion(version.Value()); project.Description = GetValue(rawProject, "description"); project.Authors = authors == null ? new string[] { } : authors.ToObject(); diff --git a/test/Microsoft.Framework.Runtime.Tests/ProjectFacts.cs b/test/Microsoft.Framework.Runtime.Tests/ProjectFacts.cs index 2cdfc0e16..701de78d8 100644 --- a/test/Microsoft.Framework.Runtime.Tests/ProjectFacts.cs +++ b/test/Microsoft.Framework.Runtime.Tests/ProjectFacts.cs @@ -9,23 +9,13 @@ namespace Microsoft.Framework.Runtime.Tests public class ProjectFacts { [Fact] - public void FallbackProjectNameIsUsedIfNoneSpecified() - { - // Arrange & Act - var project = Project.GetProject(@"{}", @"foo", @"c:\foo\project.json"); - - // Act - Assert.Equal("foo", project.Name); - } - - [Fact] - public void NameOverridesFallbackName() + public void NameIsIgnoredIsSpecified() { // Arrange & Act var project = Project.GetProject(@"{ ""name"": ""hello"" }", @"foo", @"c:\foo\project.json"); // Assert - Assert.Equal("hello", project.Name); + Assert.Equal("foo", project.Name); } [Fact]