Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

[2.1.3] Port TryAddSingleton for services #2432 #2561

Closed
BrennanConroy opened this issue Jun 28, 2018 · 3 comments
Closed

[2.1.3] Port TryAddSingleton for services #2432 #2561

BrennanConroy opened this issue Jun 28, 2018 · 3 comments
Assignees
@BrennanConroy
Milestone
2.1.3

Comments

@BrennanConroy
Copy link
Member

#2432

In 2.1.X we override user services with ours if they set them before services.AddSignalR();.
Can be pretty frustrating and difficult to figure out. Simple fix, low risk
@anurse
@BrennanConroy BrennanConroy added this to the 2.1.3 milestone Jun 28, 2018
@mikaelm12
Copy link
Contributor

Link to my commit: e41764c
It's a fairly small code change

@BrennanConroy BrennanConroy mentioned this issue Jul 3, 2018
Merged
@muratg
Copy link

muratg commented Jul 3, 2018

Approved for 2.1.3.

@BrennanConroy
Copy link
Member Author

Done

@BrennanConroy BrennanConroy self-assigned this Jul 5, 2018
This was referenced Jul 30, 2021
Closed
Closed
Closed
This was referenced Sep 6, 2021
Closed
Closed
@renovate-bot renovate-bot mentioned this issue Sep 25, 2021
Closed
1 task
@renovate-bot renovate-bot mentioned this issue Oct 4, 2021
Open
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BrennanConroy BrennanConroy

Labels
None yet
Projects
None yet
Milestone
2.1.3
Development

No branches or pull requests
4 participants
@analogrelay @muratg @mikaelm12 @BrennanConroy