Skip to content
This repository was archived by the owner on Nov 27, 2018. It is now read-only.

Data Tokens support #45

Closed
NTaylorMullen opened this issue May 10, 2014 · 5 comments
Closed

Data Tokens support #45

NTaylorMullen opened this issue May 10, 2014 · 5 comments

Comments

@NTaylorMullen
Copy link
Contributor

Add data tokens and flow as part of our context objects

| 196 | 10410 | Reported By: Ryan Nowak |

@JaneZhouQ JaneZhouQ added this to the Post Alpha milestone May 14, 2014
@yishaigalatzer
Copy link
Contributor

@rynowak are we thinking about utilizing this for attribute routing? If so please pull it in, otherwise i'm moving it out post Beta

@yishaigalatzer yishaigalatzer modified the milestones: 1.0.0-rc1, Post Alpha May 23, 2014
@rynowak
Copy link
Member

rynowak commented May 23, 2014

We should discuss next week. It's extremely likely we will

@yishaigalatzer
Copy link
Contributor

We are not using data tokens for attribute routing

@yishaigalatzer
Copy link
Contributor

Couldn't find a bug for this

DataTokens needs to be added to RouteData as a Dictionary<string,object>. TemplateRoute (and MapRoute(...)) need to accept data tokens from the user. When the route matches, the values should be copied to the RouteData.DataTokens

Also consider here making it IReadOnlyDictionary<string, object>

@Eilon
Copy link
Member

Eilon commented Jun 19, 2014

The RouteData on the TemplateRoute that the user sets could very well be exposed as an IReadOnlyDictionary to someone inspecting it, but the RouteData that gets passed around in the RequestContext or wherever I think should be mutable, no?

@NTaylorMullen NTaylorMullen assigned harshgMSFT and unassigned javiercn Jul 29, 2014
@dougbu dougbu closed this as completed Aug 12, 2014
@danroth27 danroth27 changed the title Routing - Data Tokens support Data Tokens support Aug 17, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants