Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Attributes with statements (@if, @do etc.) do not accurately represent source. #897

Closed
NTaylorMullen opened this issue Dec 13, 2016 · 2 comments
Assignees
Milestone

Comments

@NTaylorMullen
Copy link
Contributor

One of the draw backs of the attributes not representing source is that instrumentation breaks down resulting in inaccurate indexes when mapping runtime code to source code.

You can see this here. There should be a space represented but there's not.

@Eilon Eilon added this to the 2.0.0 milestone Dec 19, 2016
@rynowak
Copy link
Member

rynowak commented Dec 29, 2016

Note that the new parser codebase enforces an invariant that spans must be contiguous, and all parsed text must be a member of a span. This causes several test failures that we're skipping for now.

@ajaybhargavb
Copy link
Contributor

8bba757

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants