Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Provide a non @addtaghelper way to add TagHelper descriptors #162

Closed
NTaylorMullen opened this issue Sep 28, 2014 · 9 comments
Closed

Provide a non @addtaghelper way to add TagHelper descriptors #162

NTaylorMullen opened this issue Sep 28, 2014 · 9 comments

Comments

@NTaylorMullen
Copy link
Contributor

Right now you can do this by replacing the entire TagHelperDescriptorResolver which is obviously pretty heavy handed so we should put in an extensibility point to support this.

@danroth27 danroth27 modified the milestone: 4.0.0-rc1 Oct 17, 2014
@DamianEdwards DamianEdwards modified the milestones: Backlog, 4.0.0-rc1 Nov 26, 2014
@NTaylorMullen NTaylorMullen changed the title Tag Helpers: Provide a non @addtaghelper way to add TagHelper descriptors. Provide a non @addtaghelper way to add TagHelper descriptors. Jan 23, 2015
@Eilon
Copy link
Member

Eilon commented Mar 4, 2017

@DamianEdwards @NTaylorMullen @rynowak is this a real thing? Who would use this?

@NTaylorMullen
Copy link
Contributor Author

Orchard would use this for custom TagHelper types (shapes); however, when this issue was initially written it was to address problems like app-insights/glimpse needing to inject script tags in the body without using an @addTagHelper.

I'd say it's still valuable even for us since we'd use it for VIewComponentTagHElpers (it's hacked together to make that work today).

@Eilon
Copy link
Member

Eilon commented Mar 6, 2017

We have a different solution for Application Insights and Glimpse, which is to have a default head/body tag helper that they can inject content into: aspnet/Mvc#5728

Is it a big chunk of design work to come up with something cleaner for VCTH's?

@NTaylorMullen
Copy link
Contributor Author

Is it a big chunk of design work to come up with something cleaner for VCTH's?

Ehh, not too much but not free. I can see this issue as open or closed; we've lived this long without a first class API. Can live a while longer 😄

@rynowak
Copy link
Member

rynowak commented Mar 6, 2017

We should do this for 2.0.0 since the VCTH feature is currently hardcoded into Razor.

@DamianEdwards
Copy link
Member

Do we have an idea how this would work?

@rynowak
Copy link
Member

rynowak commented Mar 7, 2017

I think of this issue as tracking basically the support for VCTH and allowing 3rd party frameworks to do similar things (Orchard).

Similar to adding a custom directive - it's something that frameworks can do - but you need to be aware of tooling-related concerns to do it.


I don't think we should make this a user-space feature for 2.0.0. Things like <head> and <body> Tag Helpers fill a lot of the gaps that existed here in the past for libraries, and we have ideas for the future about users writing their own Tag Helpers via Razor.

@danroth27 danroth27 changed the title Provide a non @addtaghelper way to add TagHelper descriptors. Provide a non @addtaghelper way to add TagHelper descriptors Mar 8, 2017
@danroth27 danroth27 removed the feature label Mar 8, 2017
@rynowak
Copy link
Member

rynowak commented Apr 10, 2017

This is not critical for the 15.3 update, but we should try and solve it for 2.0.0 RTM

@rynowak rynowak self-assigned this Apr 28, 2017
@rynowak
Copy link
Member

rynowak commented May 16, 2017

ad294fb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants