Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Port #7770 fix to 2.1.2 or 2.1.3 #7970

Closed
dougbu opened this issue Jun 25, 2018 · 3 comments
Closed

Port #7770 fix to 2.1.2 or 2.1.3 #7970

dougbu opened this issue Jun 25, 2018 · 3 comments
Assignees
Labels
PRI: 2 - Preferred Preferably should be handled during the milestone.
Milestone

Comments

@dougbu
Copy link
Member

dougbu commented Jun 25, 2018

Suggest we port the #7770 fix (49c653e) to the next 2.1 patch. Basically [ApiController] causes a regression in some scenarios.

/cc @Eilon @mkArtakMSFT

@dougbu dougbu added this to the 2.1.3 milestone Jun 25, 2018
@dougbu dougbu added the servicing-consider Shiproom approval is required for the issue label Jun 25, 2018
@mkArtakMSFT
Copy link
Member

Given the super simple workaround customers facing this issue can apply, I don't think this will get approved as a patch candidate. Still, I will try to get this approved in Shiproom.

@mkArtakMSFT mkArtakMSFT added PRI: 2 - Preferred Preferably should be handled during the milestone. and removed servicing-consider Shiproom approval is required for the issue labels Jul 9, 2018
@mkArtakMSFT
Copy link
Member

Actually, thinking more about this, this is not even close to the bar for a patch. Closing this.

@dougbu
Copy link
Member Author

dougbu commented Jul 10, 2018

@mkArtakMSFT we introduced the #7770 regression in a patch (2.1.1). I'm surprised fix for that doesn't meet the bar for a subsequent patch. We shouldn't break scenarios in a patch -- ever.

In addition, the IFormFileCollection workaround may be simple but isn't particularly obvious.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PRI: 2 - Preferred Preferably should be handled during the milestone.
Projects
None yet
Development

No branches or pull requests

2 participants