Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Move HttpContext property from OutputFormatterWriteContext to OutputFormatterCanWriteContext #5272

Closed
khellang opened this issue Sep 13, 2016 · 3 comments
Closed

Move HttpContext property from OutputFormatterWriteContext to OutputFormatterCanWriteContext #5272

khellang opened this issue Sep 13, 2016 · 3 comments
Labels
3 - Done bug
Milestone
1.1.0

Comments

@khellang
Copy link
Contributor

khellang commented Sep 13, 2016 •
edited
Loading

I'm doing some resource versioning using an IOutputFormatter and would like to provide other mechanisms of versioning than just using the Accept header, like using a custom header, or even the URI for that matter.

This is not possible today (AFAIK) because theHttpContext property sits in OutputFormatterWriteContext rather than OutputFormatterCanWriteContext.

Would it be possible to move the property up a level? See dev...khellang:move-http-context-up for an idea of what I'm talking about.
@danroth27
Copy link
Member

This sounds reasonable to me. @Eilon @rynowak Any concerns?

@rynowak
Copy link
Member

rynowak commented Sep 23, 2016

yeah seems fine, this just seems like an oversight on our part

@khellang khellang mentioned this issue Sep 23, 2016
Closed
@Eilon Eilon added this to the 1.1.0 milestone Nov 3, 2016
@Eilon
Copy link
Member

Eilon commented Nov 3, 2016

Looks like #5316 was merged but we forgot to close this issue.

@Eilon Eilon closed this as completed Nov 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
3 - Done bug
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
4 participants
@Eilon @khellang @rynowak @danroth27