Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

RequireHttps should be redirect 302 (not 301) #4578

Closed
Eilon opened this issue May 2, 2016 · 6 comments
Closed

RequireHttps should be redirect 302 (not 301) #4578

Eilon opened this issue May 2, 2016 · 6 comments
Assignees
@kichalla
Labels
3 - Done bug
Milestone
1.0.0-rc2

Comments

@Eilon
Copy link
Member

Eilon commented May 2, 2016

See #4561.

In this bug we just want to change the default, nothing more. In the other bug we'll make it configurable.
@Eilon Eilon added this to the 1.0.0-rc2 milestone May 2, 2016
@Eilon
Copy link
Member Author

Eilon commented May 2, 2016

@kichalla another RC2 gift for you 😄

@Eilon Eilon mentioned this issue May 2, 2016
Closed
@khellang
Copy link
Contributor

khellang commented May 2, 2016

I have a PR ready for this. Do you want it on the release branch?

@Eilon
Copy link
Member Author

Eilon commented May 2, 2016

@khellang release would be great. Then @kichalla can port to dev.

@khellang khellang mentioned this issue May 2, 2016
Closed
@khellang
Copy link
Contributor

khellang commented May 2, 2016

I started out the PR looking at #4561, so it also includes the configurability. I hope that's OK 😄

@Eilon
Copy link
Member Author

Eilon commented May 3, 2016

@khellang I mentioned this in the PR (thanks for submitting it!) but unfortunately I think for release (RC2) we want to take just the change for 302. We are trying to minimize the risk as much as possible.

@kichalla
Copy link
Member

kichalla commented May 3, 2016

3c2bdfd

@kichalla kichalla closed this as completed May 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kichalla kichalla

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
3 participants
@Eilon @khellang @kichalla