Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Add more diagnostic logging in MVC #3193

Closed
rynowak opened this issue Sep 24, 2015 · 5 comments
Closed

Add more diagnostic logging in MVC #3193

rynowak opened this issue Sep 24, 2015 · 5 comments
Assignees
Milestone

Comments

@rynowak
Copy link
Member

rynowak commented Sep 24, 2015

From offline logging discussion:

Add Verbose logging where it can be useful for debugging

  • Time box to 2 dev-days maximum
  • Use EventIds at each logging statement
  • Update any existing logging to include an EventId

Relevant logging points we want to include for sure:

MVC:
        - Controller/Action (about to be run, would like to include MB data, include ModelState.IsValid) - Information
        - Action Result (each of them) - Information

@Eilon Eilon added this to the 6.0.0-rc1 milestone Sep 24, 2015
@Eilon
Copy link
Member

Eilon commented Oct 20, 2015

@ryanbrandenburg please turn 180 degrees and find the nearest other Ryan. He can point you in the right direction for this 😄

This PR should end up fairly similar to aspnet/Security#530

@rynowak
Copy link
Member Author

rynowak commented Oct 20, 2015

I was hoping we could also incorporate the new logging paradigm here.

@Eilon
Copy link
Member

Eilon commented Oct 20, 2015

Ah using LoggerDefinitions? That would be awesome!

@rynowak
Copy link
Member Author

rynowak commented Oct 21, 2015

da731fc contains part of this, there is still plenty of logging using the older paradigm that needs to be updated

@Eilon Eilon modified the milestones: 6.0.0-rc1, 6.0.0-rc2 Oct 27, 2015
@ryanbrandenburg
Copy link
Contributor

Fixed in #3387

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants