Skip to content
This repository was archived by the owner on Nov 1, 2018. It is now read-only.

Move SqliteEngine.UseWinSqlite3 to Internal for now #262

Closed
bricelam opened this issue Jun 2, 2016 · 4 comments
Closed

Move SqliteEngine.UseWinSqlite3 to Internal for now #262

bricelam opened this issue Jun 2, 2016 · 4 comments
Assignees
Milestone

Comments

@bricelam
Copy link
Contributor

bricelam commented Jun 2, 2016

Given the issues mentioned in #249, the whole point of using winsqlite3.dll is kind of moot. We should remove it for RTM and look at better ways of enabling it in the future.

@bricelam bricelam added this to the 1.0.0 milestone Jun 2, 2016
@bricelam bricelam self-assigned this Jun 2, 2016
@natemcmaster
Copy link
Contributor

But the API works on desktop for Windows 10, right?

@bricelam
Copy link
Contributor Author

bricelam commented Jun 3, 2016

It "works", but .NET Native still requires sqlite3.dll to be present and loads it, so there's no point in using the in-the-box version.

@bricelam
Copy link
Contributor Author

bricelam commented Jun 3, 2016

Re-marking for triage. As @natemcmaster pointed out, this would also cut the feature for non-.NET Native, Windows 10 users who are currently using it. (Since it also works outside of UWP.)

@bricelam bricelam removed this from the 1.0.0 milestone Jun 3, 2016
@divega
Copy link

divega commented Jun 3, 2016

@natemcmaster suggested in the PR that we could make the API internal for RTM, and I personally believe that may be an acceptable compromise as it means we can eventually remove it if we come up with something different.

@bricelam bricelam changed the title Remove SqliteEngine.UseWinSqlite3 for now Move SqliteEngine.UseWinSqlite3 to Internal for now Jun 3, 2016
@divega divega added this to the 1.0.0 milestone Jun 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants