You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 13, 2018. It is now read-only.
As a result, Loggers are only updated with new settings when the options changes, and only the loggers already registered at the time the options are loaded are updated, new loggers get default settings.
As a result, Loggers are only updated with new settings when the options changes, and only the loggers already registered at the time the options are loaded are updated, new loggers get default settings.
This is because the constructor doesn't initialize
_settings
with the current value: https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Extensions.Logging.Console/ConsoleLoggerProvider.cs#L39Then when a logger is created, it uses the non-existent
_settings
which means it falls back to default behavior: https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Extensions.Logging.Console/ConsoleLoggerProvider.cs#L105/cc @davidfowl @pakrym
@Eilon @muratg This is necessary for RTM and a fairly trivial fix.
The text was updated successfully, but these errors were encountered: