Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Clean up property behavior and doc comments for AzureAppServicesDiagnosticsSettings #506

Closed
Eilon opened this issue Nov 3, 2016 · 2 comments
Closed

Clean up property behavior and doc comments for AzureAppServicesDiagnosticsSettings #506

Eilon opened this issue Nov 3, 2016 · 2 comments
Assignees
@pakrym
Labels
3 - Done bug
Milestone
1.1.0

Comments

@Eilon
Copy link
Member

Eilon commented Nov 3, 2016

Some random stuff I noticed:

  1. The property setters should throw ArgOutOfRange w/ appropriate message for invalid values
  2. BackgroundQueueSize has no proper doc comment
  3. The non-doc comment comment for BackgroundQueueSize has a typo: Gets of sets ... --> Gets or sets ...
  4. Would probably be nice for the doc comments to indicate the actual default values, e.g. The default value for this property is <c>FOO</c>. or whatever the right doc comment syntax is.

@muratg we should do this for 1.1.0.
@Eilon
Copy link
Member Author

Eilon commented Nov 3, 2016

(Or whatever version this thing is.)

@muratg muratg added this to the 1.1.0 milestone Nov 3, 2016
@muratg
Copy link

muratg commented Nov 3, 2016

@muratg muratg mentioned this issue Nov 3, 2016
Closed
@pakrym pakrym mentioned this issue Nov 3, 2016
Merged
@pakrym pakrym added 3 - Done and removed 1 - Ready labels Nov 4, 2016
@pakrym pakrym closed this as completed Nov 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pakrym pakrym

Labels
3 - Done bug
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@Eilon @pakrym @muratg