Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

'AddProvider' on LoggerFactory should throw ObjectDisposedException after being disposed #418

Closed
artganify opened this issue May 9, 2016 · 0 comments
Assignees

Comments

@artganify
Copy link

artganify commented May 9, 2016

Simple scenario:

var loggerFactory = new LoggerFactory();
loggerFactory.Dispose();
loggerFactory.AddProvider(new LoggerProviderWithUnmanagedResources());
loggerFactory.Dispose();

The Dispose() on each ILoggerProvider is never being called a second time because the private member _disposed in LoggerFactory prevents a second call. An ObjectDisposedException is expected here.

Worth considering?

@artganify artganify changed the title 'AddProvider' on ILoggerFactory should throw ObjectDisposedException after being disposed. 'AddProvider' on LoggerFactory should throw ObjectDisposedException after being disposed May 9, 2016
@muratg muratg added the bug label May 9, 2016
@muratg muratg added this to the 1.0.0 milestone May 9, 2016
@muratg muratg modified the milestones: 1.0.1, 1.0.0 May 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants