Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Add LoggerMessage.Define overloads for 0, 4, 5, and 6 args #272

Closed
victorhurdugaci opened this issue Oct 23, 2015 · 2 comments
Closed

Add LoggerMessage.Define overloads for 0, 4, 5, and 6 args #272

victorhurdugaci opened this issue Oct 23, 2015 · 2 comments
Assignees
Milestone

Comments

@victorhurdugaci
Copy link
Contributor

Please add a non generic version of LoggerMessage.Define because there are cases in which the logged message doesn't have any parameters

@kichalla
Copy link
Member

Ideally using Define is not required in the case where you are not using a message format string and do not have any parameters to pass. Define was optimized for these cases for perf reasons.

That said, we currently have an extension for DefineScope which does not take in any arguments...probably this should be removed to keep it consistent with Define @rynowak
https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Extensions.Logging.Abstractions/LoggerMessage.cs#L20

@Eilon Eilon added this to the 1.0.0-rc2 milestone Nov 18, 2015
@Eilon Eilon changed the title LoggerMessage.Define without any argument Add LoggerMessage.Define overloads for 0, 4, 5, and 6 args Nov 18, 2015
@Eilon
Copy link
Member

Eilon commented Nov 18, 2015

We should have overloads for: no parameters, and also need to add overloads for 4, 5, and 6 args.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants