-
Notifications
You must be signed in to change notification settings - Fork 245
Add a DebugLoggerProvider that writes to Debug.WriteLine #194
Comments
It will be nice if the logger will be added automatically by the runtime if the debugger is attached |
@kichalla We can potentially do this in DNX by bringing logging abstractions to DNX layer when you bring ILogger to DNX. Shouldn't be it's own package. Will require an update in Hosting too. |
i would avoid the dnx for now and keep it localized to hosting |
@davidfowl any particular reason? Because of the churn we're expecting in the DNX? We have other issues RE bringing the |
Putting things int the dnx requires care in order to avoid pinning before the application loads. That plus the currently refactoring going on it seems unwise to make that layering decision at this point. We need an easy way to move things without pinning it before the app runs |
If that's the case why don't we just put it in the templates only? Hosting still isn't really optional for apps anyway so maybe better to require it to be added by the app explicitly. |
+1. We should at least do the feature for beta6 it's trivial. We can discuss moving it in by default at a later date. |
K. What package should we put it in? Microsoft.Framework.Logging? |
Separate package like the other providers |
And you get a package! And you get a package! You all get packages! |
@davidfowl and @DamianEdwards do you like |
@victorhurdugaci yeah that's fine |
@DamianEdwards, @davidfowl do you want the template to add the logger or do you want it in hosting? |
All of the project templates, inc. Empty. |
The templates part of this issue is here: aspnet/Templates#124 |
Would be almost identical to the existing
ConsoleLoggerProvider
but it would write toDebug.WriteLine
. It would enable itself only when the debugger is attached.We should have this provider in the runtime by default so that any app will log messages to the debugger output, e.g. in Visual Studio.
The text was updated successfully, but these errors were encountered: