Skip to content
This repository was archived by the owner on Dec 18, 2017. It is now read-only.

Null ref in RemotePackageWalker #145

Closed
davidfowl opened this issue May 4, 2014 · 2 comments
Closed

Null ref in RemotePackageWalker #145

davidfowl opened this issue May 4, 2014 · 2 comments
Assignees
Milestone

Comments

@davidfowl
Copy link
Member

http://projectk-tc/viewLog.html?buildId=11729&buildTypeId=WebListener&tab=buildLog#_focus=2440

/cc @loudej

Looks like restore failed here

@davidfowl davidfowl added this to the Alpha milestone May 4, 2014
@davidfowl
Copy link
Member Author

I worked around it to unblock coherence but it might be a case sensitivity thing. See the diff that fixed it here:

aspnet/HttpSysServer@21616bc

@davidfowl davidfowl modified the milestones: Post Alpha, Alpha May 14, 2014
@jeremymeng
Copy link

When downloading zip files it seems working regardless of the casing. However when getting the .nuspec file from the downloaded zip file, it is case-sensitive. We should give users proper error message instead of a null ref exception.

        public async Task<Stream> OpenNuspecStreamAsync(PackageInfo package)
        {
            using (var nupkgStream = await OpenNupkgStreamAsync(package))
            {
                using (var archive = new ZipArchive(nupkgStream, ZipArchiveMode.Read, leaveOpen: true))
                {
                    var entry = archive.GetEntry(package.Id + ".nuspec");
                    using (var entryStream = entry.Open())
                    {

@davidfowl davidfowl assigned ChengTian and unassigned loudej Jun 10, 2014
@davidfowl davidfowl modified the milestones: Alpha, Post Alpha, CTP2 Jun 10, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants