Skip to content
This repository was archived by the owner on Dec 18, 2017. It is now read-only.

ignore comments from json file while parsing json file at runtime #120

Closed
anandparanjape opened this issue Apr 24, 2014 · 15 comments
Closed

Comments

@anandparanjape
Copy link

JSON.NET supports comments now and K runtime needs to support that.
TSF#931826

User scenario is to add comments in project.json file. comment packages from project.json file. JSON Editor supports this.

@sayedihashimi
Copy link

Are we on track to get this in for Alpha?

@sayedihashimi
Copy link

I don't have access to edit labels, do we have a bug label that should be applied here?

@davidfowl
Copy link
Member

This isn't being looked at for alpha.

@davidfowl davidfowl added the bug label May 7, 2014
@Eilon
Copy link
Member

Eilon commented May 7, 2014

Yeah I don't think the runtime supports comments in project.json yet and it won't be for alpha. We do support JSON comments in config files (e.g. config.json) but I think that's it.

@sayedihashimi
Copy link

Thanks @Eilon, how about the next release? Any concerns with enabling it?

@Eilon
Copy link
Member

Eilon commented May 13, 2014

I think it's something we'll want to enable - can you log a bug in KRuntime?

@anandparanjape
Copy link
Author

Eilon, I opened this bug for same ask in KRuntime.

@davidfowl
Copy link
Member

We already support /**/. Closing this as won't fix.

@anandparanjape
Copy link
Author

Editor supports // type of comments as well. Runtime needs to support that

Sent from my Windows Phone


From: David Fowlermailto:[email protected]
Sent: ‎5/‎27/‎2014 2:22 PM
To: aspnet/KRuntimemailto:[email protected]
Cc: Anand Paranjapemailto:[email protected]
Subject: Re: [KRuntime] ignore comments from json file while parsing json file at runtime (#120)

We already support /**/. Closing this as won't fix.


Reply to this email directly or view it on GitHub:
#120 (comment)

@davidfowl
Copy link
Member

Ok, I'll leave this in the backlog until we pick a version of JSON.NET that supports this.

@davidfowl davidfowl reopened this May 27, 2014
@JamesNK
Copy link
Member

JamesNK commented Jun 27, 2014

Json.NET 6 supports // comments.

@anandparanjape
Copy link
Author

Is this getting in CTP4?

@davidfowl
Copy link
Member

It should already be in

@anandparanjape
Copy link
Author

Yes.. it is... I just verified. Thanks David!!

@glennc glennc added this to the 1.0.0-alpha4 milestone Sep 30, 2014
@glennc
Copy link
Member

glennc commented Sep 30, 2014

Done, assigned to milestone.

@glennc glennc closed this as completed Sep 30, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants