Skip to content
This repository was archived by the owner on Nov 15, 2018. It is now read-only.

Missing support for JSON Pointer Escaping #44

Closed
sandorfr opened this issue Oct 8, 2016 · 3 comments
Closed

Missing support for JSON Pointer Escaping #44

sandorfr opened this issue Oct 8, 2016 · 3 comments
Assignees
@kichalla
Labels
3 - Done bug
Milestone
1.1.0

Comments

@sandorfr
Copy link
Contributor

sandorfr commented Oct 8, 2016

The following JSON is valid:

{
  "foo/bar~" : "a value"
}

But currently the library does not support ~ and / as stated under JSON Pointer section, so this can't be patched.

I'll open a pull request with a fix proposal.
@sandorfr sandorfr mentioned this issue Oct 8, 2016
Closed
@Eilon Eilon added this to the 1.2.0 milestone Oct 27, 2016
@Eilon Eilon modified the milestones: 1.1.0, 1.2.0 Nov 7, 2016
@Eilon
Copy link
Member

Eilon commented Nov 7, 2016

@kichalla do you have time to review the PR for this today? I'd like to get this into 1.1.0.

@kichalla
Copy link
Member

kichalla commented Nov 8, 2016

@Eilon Sorry I actually didn't see the notification about this until few minutes back. Taking a look now.

@Eilon Eilon added 3 - Done and removed 1 - Ready labels Nov 8, 2016
@Eilon
Copy link
Member

Eilon commented Nov 8, 2016

Looks like you merged this, so closing. Thanks!

@Eilon Eilon closed this as completed Nov 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kichalla kichalla

Labels
3 - Done bug
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@Eilon @sandorfr @kichalla