Skip to content
This repository was archived by the owner on Dec 20, 2018. It is now read-only.

Consider backing out schema changes store versioning until 2.1 #1278

Closed
HaoK opened this issue Jun 12, 2017 · 4 comments
Closed

Consider backing out schema changes store versioning until 2.1 #1278

HaoK opened this issue Jun 12, 2017 · 4 comments
Assignees
Milestone

Comments

@HaoK
Copy link
Member

HaoK commented Jun 12, 2017

We should consider backing out be8232d since identity service didn't make it into 2.0, this would give us more time to react/update things without having backcompat issues.

The main motivation from my perspective is not introducing a 2.0 schema change that only adds 2 properties, that seems like a waste.

There doesn't appear to be anything preventing us from bringing all of this back as a new feature in 2.1 as it doesn't affect anything outside of the EntityFrameworkCore.

We'd also back out the new activity/sign in/ password feature as well since that's what drove the schema changes.

cc @ajcvickers @divega @blowdart

@HaoK
Copy link
Member Author

HaoK commented Jun 12, 2017

Basically we should only add this complexity when we have a large schema update/optional features that are compelling enough to justify all of this stuff...

@HaoK HaoK self-assigned this Jun 13, 2017
@HaoK HaoK added this to the 2.0.0 milestone Jun 13, 2017
@HaoK
Copy link
Member Author

HaoK commented Jun 13, 2017

After talking to @ajcvickers plan is to back these out for now, we can add this back along with our next schema update, most likely in 2.1

We'll be focusing on making Roles optional at the new lower Microsoft.Extensions.Identity layer instead

@HaoK
Copy link
Member Author

HaoK commented Jun 13, 2017

a9192d9

@HaoK HaoK closed this as completed Jun 13, 2017
@HaoK HaoK added 3 - Done and removed 2 - Working labels Jun 13, 2017
@kinosang
Copy link

Will this feature be add back for 2.1?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants