Skip to content
This repository was archived by the owner on Dec 20, 2018. It is now read-only.

Move IdentityOptions from Microsoft.AspNetCore.Builder to identity namespace #1261

Closed
HaoK opened this issue Jun 2, 2017 · 7 comments
Closed
Assignees
Milestone

Comments

@HaoK
Copy link
Member

HaoK commented Jun 2, 2017

I guess it has been in Microsoft.AspNetCore.Builder all this time, this used to be the pattern so intellesense would work before we switched consistently to lambdas everywhere... Seems like we should welcome the options class home. This realistically shouldn't break many apps, as its rare for the options type to be used by itself without any other identity classes... Maybe something we can do post preview 2... @ajcvickers

@HaoK
Copy link
Member Author

HaoK commented Jun 2, 2017

The benefit isn't that big, so I don't think its worth adding any build stability issues to try and slam it in right now

@kevinchalet
Copy link

If you do that, please also consider moving all the scheme handlers options (in aspnet/Security) to their respective repos 😄

@HaoK
Copy link
Member Author

HaoK commented Jun 5, 2017

You mean moving the options for the security/auth handlers to the right namespace? I think they are in the right repo today :)

@kevinchalet
Copy link

lol yeah, I meant namespace, not repo, sorry for the confusion 😅

@HaoK
Copy link
Member Author

HaoK commented Jun 27, 2017

@ajcvickers ok for me to move the options type to the proper namespace now? We already moved it to a different assembly in (Extensions), might as well move it to the proper home namespace

@ajcvickers
Copy link
Contributor

Yes

@HaoK HaoK self-assigned this Jun 28, 2017
@HaoK HaoK added this to the 2.0.0 milestone Jun 28, 2017
@HaoK HaoK added 3 - Done and removed 2 - Working labels Jun 29, 2017
@HaoK
Copy link
Member Author

HaoK commented Jun 29, 2017

eb3ff7f

@HaoK HaoK closed this as completed Jun 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants