Skip to content
This repository was archived by the owner on Dec 20, 2018. It is now read-only.

GetRolesAsync missing cancellation token pass in EntityFramework UserStore #1143

Closed
ghost opened this issue Mar 23, 2017 · 1 comment
Closed
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Mar 23, 2017

https://github.com/aspnet/Identity/blob/dev/src/Microsoft.AspNetCore.Identity.EntityFrameworkCore/UserStore.cs

The last line of the GetRolesAsync method is:

return await query.ToListAsync();

This should be passed the cancellation token and is inconsistent with the rest of the class, i.e.

return await query.ToListAsync(cancellationToken);

@blowdart blowdart added the bug label Mar 29, 2017
@HaoK HaoK added this to the 2.0.0 milestone Apr 27, 2017
@HaoK
Copy link
Member

HaoK commented Jun 14, 2017

a1b9857

@HaoK HaoK closed this as completed Jun 14, 2017
@HaoK HaoK added 3 - Done and removed 2 - Working labels Jun 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants