Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Add support for SameSite cookie property #710

Closed
blowdart opened this issue Sep 12, 2016 · 8 comments
Closed

Add support for SameSite cookie property #710

blowdart opened this issue Sep 12, 2016 · 8 comments

Comments

@blowdart
Copy link
Member

https://tools.ietf.org/html/draft-west-first-party-cookies-07

Basically add a new property SameSite with values of None, Lax and Strict.

The value should then be appended to cookies when the cookie is sent;

Set-Cookie: CookieName=CookieValue; SameSite=Lax;
Set-Cookie: CookieName=CookieValue; SameSite=Strict;
@Tratcher
Copy link
Member

This has come up before (though I can't find the issue). We were going to wait for the RFC to finish.

@blowdart
Copy link
Member Author

Yea I couldn't find it either, I thought I had logged it before. I figured better safe than sorry.

@Tratcher
Copy link
Member

This sounds like something that should be added to the CookiePolicy middleware.

@blowdart
Copy link
Member Author

Not so sure, after all we can set HTTP_Only and Secure on individual cookies, via CookieOptions. I feel it ought to go in there, along with the ability to override everything in the CookiePolicy middleware.

@Tratcher
Copy link
Member

Yes, I meant in addition to implementing it here.

@blowdart
Copy link
Member Author

Ah :)

@muratg
Copy link

muratg commented Sep 23, 2016

Backlogging until spec is more stable. Ping me if you think otherwise.

@Tratcher
Copy link
Member

@blowdart has requested a re-triage

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants