Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Make WebHost internal to avoid type conflict #1030

Closed
JunTaoLuo opened this issue Apr 20, 2017 · 1 comment
Closed

Make WebHost internal to avoid type conflict #1030

JunTaoLuo opened this issue Apr 20, 2017 · 1 comment
Assignees
@JunTaoLuo
Labels
3 - Done bug
Milestone
2.0.0-preview1

Comments

@JunTaoLuo
Copy link
Contributor

The type lives in the Microsoft.AspNetCore.Hosting.Internal namespace. Now that we have the WebHost as a public type in Microsft.AspNetCore that contains the static APIs, we should rename the one in hosting to prevent potential type conflicts.

HostingWebHost, InternalWebHost?

Note that this should not happen often since it's unlikely that anyone should be using the M.A.Hosting.Internal namespace.
@JunTaoLuo
Copy link
Contributor Author

Could also potentially make the WebHost internal instead of public but @davidfowl seems to prefer renaming it instead.

@JunTaoLuo JunTaoLuo self-assigned this Apr 23, 2017
@JunTaoLuo JunTaoLuo added this to the 2.0.0-preview1 milestone Apr 23, 2017
@JunTaoLuo JunTaoLuo mentioned this issue Apr 23, 2017
Merged
@JunTaoLuo JunTaoLuo changed the title Rename WebHost to avoid type conflict Make WebHost internal to avoid type conflict Apr 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
1 participant
@JunTaoLuo