Skip to content
This repository was archived by the owner on Nov 6, 2018. It is now read-only.

File globbing should support pattern checks #194

Closed
victorhurdugaci opened this issue May 24, 2016 · 4 comments
Closed

File globbing should support pattern checks #194

victorhurdugaci opened this issue May 24, 2016 · 4 comments

Comments

@victorhurdugaci
Copy link
Contributor

Today you cannot check if if a path matches a pattern without executing the globbing pattern (aka going to disk). This slows down dotnet watch a lot because on every file change it has to go to the disk, fetch all files and the see if the changed file is in the resulting list.

@pranavkm
Copy link
Contributor

@victorhurdugaci
Copy link
Contributor Author

victorhurdugaci commented May 24, 2016

Nope. What I want to do is, given:

  1. Base path: /foo
  2. Pattern: **/*.js

Tell me if /foo/baz/bar.js matches that without going to the disk.

@muratg muratg added this to the 1.0.1 milestone May 26, 2016
@dazinator
Copy link
Contributor

dazinator commented Jul 25, 2016

Tell me if /foo/baz/bar.js matches that without going to the disk.

Yes please! Does globbing only work with PhysicalFileProvider currently then?

I'd like to take:

  1. A pattern **/*.js
  2. An IEnumerable<string> paths - {"some/path/file1.js", "some/path/file2.js", "someother/file/one.txt"}

Tell me what the matches are (without going to disk)

This way, I can easily use globbing within my own IFileProviders too.

@BrennanConroy
Copy link
Member

767f07f

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants