Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-process model snapshot to massage metadata #8925

Closed
ajcvickers opened this issue Jun 21, 2017 · 2 comments
Closed

Post-process model snapshot to massage metadata #8925

ajcvickers opened this issue Jun 21, 2017 · 2 comments
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
2.0.0

Comments

@ajcvickers
Copy link
Contributor

The model snapshot may contain provider-specific annotations that are now only supported as relational annotation. For example, SqlServer:TableName. After building the snapshot we could process it to change these to Relational:Xxx based on looking for any annotation that ends in :SomeRelationalAnnotation. If this results in conflict (should be rare) we can pick one and warn saying that this is not supported anymore--note that it wouldn't have worked in migrations anyway.

This hook could also be generally useful in the future for other tweaks to metadata that may result in residual code in the snapshot that needs to be massaged.
@ajcvickers ajcvickers changed the title Consider post-processing model snapshot to massage metadata Post-process model snapshot to massage metadata Jun 21, 2017
@ajcvickers
Copy link
Contributor Author

Look at the version and only do it when needed.

@ajcvickers ajcvickers added this to the 2.0.0 milestone Jun 21, 2017
@AndriySvyryd
Copy link
Member

@smitpatel Poaching this

@ajcvickers ajcvickers assigned ajcvickers and unassigned AndriySvyryd Jul 6, 2017
ajcvickers added a commit that referenced this issue Jul 6, 2017
@ajcvickers
Post-process the snapshot model to remove/combine legacy provider-spe…
a226c38 
…cific annotations

Issue #8925

Currently relies on the model elements from the snapshot being mutable, but API could return a new IModel instead if this ever becomes not true.
@ajcvickers ajcvickers mentioned this issue Jul 6, 2017
Merged
ajcvickers added a commit that referenced this issue Jul 7, 2017
@ajcvickers
Post-process the snapshot model to remove/combine legacy provider-spe…
d5e8875 
…cific annotations

Issue #8925

Currently relies on the model elements from the snapshot being mutable, but API could return a new IModel instead if this ever becomes not true.
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 7, 2017
@ajcvickers ajcvickers mentioned this issue Aug 14, 2017
Closed
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@ajcvickers @smitpatel @AndriySvyryd