Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider throwing when a DIET instance is shared #8387

Closed
AndriySvyryd opened this issue May 4, 2017 · 1 comment
Closed

Consider throwing when a DIET instance is shared #8387

AndriySvyryd opened this issue May 4, 2017 · 1 comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
2.0.0

Comments

@AndriySvyryd
Copy link
Member

At least log a warning as mutating it could lead to unexpected results if the user is not aware it's being shared.
Once we have readonly entities, they can be shared without any issues.
@ajcvickers
Copy link
Contributor

Make it a log-type error, but set to throw by default.

@ajcvickers ajcvickers added this to the 2.0.0 milestone May 5, 2017
AndriySvyryd added a commit that referenced this issue May 31, 2017
@AndriySvyryd
Log a warning when a DIET instance is shared.
8905d4a 
Fixes #8387
@AndriySvyryd AndriySvyryd mentioned this issue May 31, 2017
Merged
AndriySvyryd added a commit that referenced this issue May 31, 2017
@AndriySvyryd
Log a warning when a DIET instance is shared.
280f2ce 
Fixes #8387
@AndriySvyryd AndriySvyryd modified the milestones: 2.0.0-preview2, 2.0.0 Jun 1, 2017
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 1, 2017
@AndriySvyryd AndriySvyryd removed their assignment Jun 1, 2017
@ajcvickers ajcvickers modified the milestones: 2.0.0-preview2, 2.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@ajcvickers @AndriySvyryd