Query: Add missing translators for Math functions in SqlServer provider

[rpawlaszek]

There is quite a number of math functions not translated: Math.Exp, Math.Log10, Math.Log, Math.Sqrt, Math.Acos, Math.Asin, Math.Atan2, Math.Atan, Math.Cos, Math.Sin, Math.Tan. The implementation is as easy as for the ones translated that derive from MultipleOverloadStaticMethodCallTranslator. Could I ask to implement them? I implemented them locally and they all work fine.

Further technical details

EF Core version: all
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10 Pro
IDE: Visual Studio 2015

[rpawlaszek]

@rowanmiller what does the label "up-for-grabs" mean?

[rowanmiller]

@rpawlaszek we use it to identify items that would be good candidates for a contribution from the community. It doesn't mean we're not going to do it, just that someone from the community may want to pick it up before we get to it.

[rpawlaszek]

Great:) As I understand this includes implementing the functionality AND the tests, right? And if I would like to do it is this the procedure? Sorry if it is obvious, I just haven't done this ever before.

[rowanmiller]

@rpawlaszek correct. It is also best to start with a small contribution for your first one. So if you plan to tackle this, probably start with one method until you get the hang of how the process works and the type of feedback you get on the code review etc.

[rpawlaszek]

@rowanmiller I started with a translator for Math.Exp looking at the definition of the translator for Math.Abs, included it in _methodCallTranslators in SqlServerCompositeMethodCallTranslator and then added Where_math_exp. Any comments?

[smitpatel]

@rpawlaszek - Submit a pull request to this repo so that we can review the diff and give you feedback.

[ErikEJ]

http://ardalis.com/github-pull-request-checklist - and also check the contributing guide

[maumar]

fixed in 074fd1b

[rpawlaszek]

Just a small update as I omitted one more function that is translated 1-1: Math.Sign that Sql Server supports

[maumar]

@rpawlaszek please open new PR for that