Reverse engineering: SQL Server User Defined Data Type cannot be reverse engineered

[Axioma-ShirokovPN]

If we have some schemas with identical name of UDDT - we get error
System.ArgumentException: An item with the same key has already been added. Key: TypeId

Steps to reproduce

Create 2 schemas: Items, Users.
Create 2 UDDT: Items.TypeId (tinyint), Users.TypeId (tinyint)

After this, call:
Scaffold-DbContext "Server=localhost\SQLEXPRESS; Database=SimpleDB; User Id=Test; Password=Test; MultipleActiveResultSets=true;" Microsoft.EntityFrameworkCore.SqlServer -Force -Verbose
And you will receive:
System.ArgumentException: An item with the same key has already been added. Key: TypeId
at System.ThrowHelper.ThrowAddingDuplicateWithKeyArgumentException(Object key)
at System.Collections.Generic.Dictionary2.Insert(TKey key, TValue value, Boolean add) at Microsoft.EntityFrameworkCore.Scaffolding.Internal.SqlServerDatabaseModelFactory.GetTypeAliases() at Microsoft.EntityFrameworkCore.Scaffolding.Internal.SqlServerDatabaseModelFactory.Create(DbConnection connection, TableSelectionSet tableSelectionSet) at Microsoft.EntityFrameworkCore.Scaffolding.Internal.SqlServerDatabaseModelFactory.Create(String connectionString, TableSelectionSet tableSelectionSet) at Microsoft.EntityFrameworkCore.Scaffolding.RelationalScaffoldingModelFactory.Create(String connectionString, TableSelectionSet tableSelectionSet) at Microsoft.EntityFrameworkCore.Scaffolding.Internal.SqlServerScaffoldingModelFactory.Create(String connectionString, TableSelectionSet tableSelectionSet) at Microsoft.EntityFrameworkCore.Scaffolding.Internal.ReverseEngineeringGenerator.GetMetadataModel(ReverseEngineeringConfiguration configuration) at Microsoft.EntityFrameworkCore.Scaffolding.Internal.ReverseEngineeringGenerator.GenerateAsync(ReverseEngineeringConfiguration configuration, CancellationToken cancellationToken) at Microsoft.EntityFrameworkCore.Design.Internal.DatabaseOperations.ScaffoldContextAsync(String provider, String connectionString, String outputDir, String dbContextClassName, IEnumerable1 schemas, IEnumerable1 tables, Boolean useDataAnnotations, Boolean overwriteFiles, CancellationToken cancellationToken) at Microsoft.EntityFrameworkCore.Design.OperationExecutor.<ScaffoldContextImpl>d__22.MoveNext() at System.Collections.Generic.EnumerableHelpers.ToArray[T](IEnumerable1 source, Int32& length)
at System.Collections.Generic.EnumerableHelpers.ToArray[T](IEnumerable1 source) at System.Linq.Enumerable.ToArray[TSource](IEnumerable1 source)
at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.<>c__DisplayClass4_0`1.b__0()
at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.Execute(Action action)
An item with the same key has already been added. Key: TypeId

Why I can't have 2 UDDT with the same name in different schemas?

Further technical details

[ajcvickers]

Not sure if this is a dupe, but looks like the same scenario as #7315.

[lajones]

@ajcvickers I think this is a separate bug. In SqlServerDatabaseModelFactory the query which brings back the type aliases does not include their schema. Don't think it ever did, but it looks like it should to support the above scenario. #7315 is about failing to receive warnings which should be there. I haven't investigated yet, but we used to produce warnings, so either the situation in #7315 is somehow different from the situation where we do produce warnings, or the warnings have been mistakenly removed, or somehow the work we did on logging levels has meant they no longer display.

[Axioma-ShirokovPN]

Yes, this is separate bug, but from one category - incorrect work with UDDT.

[lajones]

Fixed with commits 0993e23 and caa6dce.

[Axioma-ShirokovPN]

I try to test it again with aspnet-1-1-2-may2017-patch-public and it not works.
I have many UDDT with name TypeId, but in different schemas and I have the same error:
An item with the same key has already been added. Key: TypeId

[lajones]

@Axioma-ShirokovPN I'm afraid the fix for this only went into the 2.0.0 release, not the 1.1.2 release. So it is not available in the aspnet-1-1-2-may2017-patch-public feed.