Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrastructure: Avoid reference counting for open and close in SQLite provider #7527

Closed
ajcvickers opened this issue Feb 1, 2017 · 0 comments
Closed

Infrastructure: Avoid reference counting for open and close in SQLite provider #7527

ajcvickers opened this issue Feb 1, 2017 · 0 comments
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-enhancement
Milestone
2.0.0

Comments

@ajcvickers
Copy link
Contributor

RelationalConnection has logic to allow consumers of the service to call open/close without having to worry about whether the connection is actually being opened or closed. SqliteRelationalConnection duplicates this code, which is fragile in that updates to the specifics in the base class might not make it into the provider class.
ajcvickers added a commit that referenced this issue Feb 1, 2017
@ajcvickers
Update IRelationalConnection to return status of Open/Close calls
d1ff79b 
Issue #7527

Removes the reference counting logic from SqliteRelationalConnection and instead uses information from the base implementation to determine if a connection was actually opened and therefore whether or not the pragma to enable FKs needs to be sent.
@ajcvickers ajcvickers mentioned this issue Feb 1, 2017
Merged
@ajcvickers ajcvickers mentioned this issue Feb 1, 2017
Closed
@ajcvickers ajcvickers self-assigned this Feb 1, 2017
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Feb 1, 2017
@ajcvickers ajcvickers added this to the 2.0.0 milestone Feb 1, 2017
@ajcvickers ajcvickers changed the title Avoid reference counting for open and close in SQLite provider Infrastructure: Avoid reference counting for open and close in SQLite provider May 9, 2017
@smitpatel smitpatel mentioned this issue Nov 23, 2017
Closed
@ajcvickers ajcvickers modified the milestones: 2.0.0-preview1, 2.0.0 Oct 15, 2022
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@ajcvickers