Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model configuration: Overlapping optional and required FKs results in attempt to null out properties inappropriately #6840

Closed
AndriySvyryd opened this issue Oct 22, 2016 · 2 comments
Closed

Model configuration: Overlapping optional and required FKs results in attempt to null out properties inappropriately #6840

AndriySvyryd opened this issue Oct 22, 2016 · 2 comments
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
2.0.0

Comments

@AndriySvyryd
Copy link
Member

No description provided.

AndriySvyryd added a commit that referenced this issue Oct 22, 2016
@AndriySvyryd
Test for #6840
6d99cc1
@rowanmiller
Copy link
Contributor

EF Team Triage: This issue is lacking enough information for us to be able to effectively triage it. In particular, it is missing the following information requested in the new issue template. Can you please provide this information?

Steps to reproduce

Ideally include a complete code listing that we can run to reproduce the issue.
Alternatively, you can provide a project/solution that we can run.

BTW we're not just doing this to be mean 😄... we get a lot traffic on this project and it takes time to attempt to reproduce an issue based on fragments of information. In addition, our attempt is often unsuccessful as the exact conditions required to hit the issue are often not explicitly included in the code provided. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we ask that folks give us a self contained way to reproduce an issue.

For a guide on submitting good bug reports, read Painless Bug Tracking.

@rowanmiller
Copy link
Contributor

:trollface:

@rowanmiller rowanmiller added this to the 1.2.0 milestone Oct 24, 2016
ajcvickers pushed a commit that referenced this issue Oct 25, 2016
@AndriySvyryd @ajcvickers
Don't attempt to null out PK parts of composite FK during fixup
5fa93fd 
Because this either throws because the PK property cannot be set to null, or marks the property as conceptually null which then causes issues later.

There were also two issues in the tests:
- Equals method of one of the entities was wrong
- Tests wouldn't run on SQLite because composite keys with store generated ints are not supported

Issue #6840
@ajcvickers ajcvickers mentioned this issue Oct 25, 2016
Merged
ajcvickers pushed a commit that referenced this issue Oct 26, 2016
@AndriySvyryd @ajcvickers
Don't attempt to null out PK parts of composite FK during fixup
5913727 
Because this either throws because the PK property cannot be set to null, or marks the property as conceptually null which then causes issues later.

There were also two issues in the tests:
- Equals method of one of the entities was wrong
- Tests wouldn't run on SQLite because composite keys with store generated ints are not supported

Issue #6840
ajcvickers pushed a commit that referenced this issue Oct 26, 2016
@AndriySvyryd @ajcvickers
Don't attempt to null out PK parts of composite FK during fixup
5b23250 
Because this either throws because the PK property cannot be set to null, or marks the property as conceptually null which then causes issues later.

There were also two issues in the tests:
- Equals method of one of the entities was wrong
- Tests wouldn't run on SQLite because composite keys with store generated ints are not supported

Issue #6840
@ajcvickers ajcvickers added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed type-investigation labels Oct 26, 2016
smitpatel pushed a commit that referenced this issue Nov 8, 2016
@AndriySvyryd @smitpatel
Don't attempt to null out PK parts of composite FK during fixup
cfea892 
Because this either throws because the PK property cannot be set to null, or marks the property as conceptually null which then causes issues later.

There were also two issues in the tests:
- Equals method of one of the entities was wrong
- Tests wouldn't run on SQLite because composite keys with store generated ints are not supported

Issue #6840
@divega divega added the type-bug label May 8, 2017
@ajcvickers ajcvickers changed the title Overlapping optional and required FKs don't work right Model configuration: Overlapping optional and required FKs results in attempt to null out properties inappropriately May 9, 2017
@divega divega added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. labels May 10, 2017
@ajcvickers ajcvickers modified the milestones: 2.0.0-preview1, 2.0.0 Oct 15, 2022
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
4 participants
@divega @ajcvickers @rowanmiller @AndriySvyryd