-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query: Include with OrderBy with Skip(0) cause OrderBy to be ignored #6736
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-bug
Milestone
Comments
smitpatel
added a commit
that referenced
this issue
Apr 6, 2017
- We dont need to copy always now since new IncludeCompiler lifts order by at query model level - Move RowNumberPagingExpressionVisitor to SqlServerQuerySqlGenerator - Remove SqlServerQueryModelVisitor - Add explicit tests for #6736
smitpatel
added a commit
that referenced
this issue
Apr 6, 2017
- We dont need to copy always now since new IncludeCompiler lifts order by at query model level - Move RowNumberPagingExpressionVisitor to SqlServerQuerySqlGenerator - Remove SqlServerQueryModelVisitor - Add explicit tests for #6736
smitpatel
added a commit
that referenced
this issue
Apr 6, 2017
- We dont need to copy always now since new IncludeCompiler lifts order by at query model level - Move RowNumberPagingExpressionVisitor to SqlServerQuerySqlGenerator - Remove SqlServerQueryModelVisitor - Add explicit tests for #6736
smitpatel
added a commit
that referenced
this issue
Apr 7, 2017
- We dont need to copy always now since new IncludeCompiler lifts order by at query model level - Move RowNumberPagingExpressionVisitor to SqlServerQuerySqlGenerator - Remove SqlServerQueryModelVisitor - Add explicit tests for #6736
smitpatel
added a commit
that referenced
this issue
Apr 7, 2017
- We dont need to copy always now since new IncludeCompiler lifts order by at query model level - Move RowNumberPagingExpressionVisitor to SqlServerQuerySqlGenerator - Remove SqlServerQueryModelVisitor - Add explicit tests for #6736
smitpatel
added a commit
that referenced
this issue
Apr 7, 2017
- We dont need to copy always now since new IncludeCompiler lifts order by at query model level - Move RowNumberPagingExpressionVisitor to SqlServerQuerySqlGenerator - Remove SqlServerQueryModelVisitor - Add explicit tests for #6736
smitpatel
added a commit
that referenced
this issue
Apr 7, 2017
- We dont need to copy always now since new IncludeCompiler lifts order by at query model level - Move RowNumberPagingExpressionVisitor to SqlServerQuerySqlGenerator - Introduce ISqlServerOptions, SqlServerOptions to flow SqlServerDbOptionsExtension to SqlServerQuerySqlGenerator as singleton service to get value of RowNumberPaging - Remove SqlServerQueryModelVisitor - Add explicit tests for #6736
smitpatel
added a commit
that referenced
this issue
Apr 7, 2017
- We dont need to copy always now since new IncludeCompiler lifts order by at query model level - Move RowNumberPagingExpressionVisitor to SqlServerQuerySqlGenerator - Introduce ISqlServerOptions, SqlServerOptions to flow SqlServerDbOptionsExtension to SqlServerQuerySqlGenerator as singleton service to get value of RowNumberPaging - Remove SqlServerQueryModelVisitor - Add explicit tests for #6736
smitpatel
added a commit
that referenced
this issue
Apr 7, 2017
- We dont need to copy always now since new IncludeCompiler lifts order by at query model level - Move RowNumberPagingExpressionVisitor to SqlServerQuerySqlGenerator - Introduce ISqlServerOptions, SqlServerOptions to flow SqlServerDbOptionsExtension to SqlServerQuerySqlGenerator as singleton service to get value of RowNumberPaging - Remove SqlServerQueryModelVisitor - Add explicit tests for #6736
smitpatel
added a commit
that referenced
this issue
Apr 7, 2017
- We dont need to copy always now since new IncludeCompiler lifts order by at query model level - Move RowNumberPagingExpressionVisitor to SqlServerQuerySqlGenerator - Introduce ISqlServerOptions, SqlServerOptions to flow SqlServerDbOptionsExtension to SqlServerQuerySqlGenerator as singleton service to get value of RowNumberPaging - Remove SqlServerQueryModelVisitor - Add explicit tests for #6736
smitpatel
added a commit
that referenced
this issue
Apr 7, 2017
- We dont need to copy always now since new IncludeCompiler lifts order by at query model level - Move RowNumberPagingExpressionVisitor to SqlServerQuerySqlGenerator - Introduce ISqlServerOptions, SqlServerOptions to flow SqlServerDbOptionsExtension to SqlServerQuerySqlGenerator as singleton service to get value of RowNumberPaging - Remove SqlServerQueryModelVisitor - Add explicit tests for #6736
smitpatel
added a commit
that referenced
this issue
Apr 7, 2017
- We dont need to copy always now since new IncludeCompiler lifts order by at query model level - Move RowNumberPagingExpressionVisitor to SqlServerQuerySqlGenerator - Introduce ISqlServerOptions, SqlServerOptions to flow SqlServerDbOptionsExtension to SqlServerQuerySqlGenerator as singleton service to get value of RowNumberPaging - Remove SqlServerQueryModelVisitor - Add explicit tests for #6736
smitpatel
added a commit
that referenced
this issue
Apr 7, 2017
- We dont need to copy always now since new IncludeCompiler lifts order by at query model level - Move RowNumberPagingExpressionVisitor to SqlServerQuerySqlGenerator - Introduce ISqlServerOptions, SqlServerOptions to flow SqlServerDbOptionsExtension to SqlServerQuerySqlGenerator as singleton service to get value of RowNumberPaging - Remove SqlServerQueryModelVisitor - Add explicit tests for #6736
smitpatel
added a commit
that referenced
this issue
Apr 10, 2017
- We dont need to copy always now since new IncludeCompiler lifts order by at query model level - Move RowNumberPagingExpressionVisitor to SqlServerQuerySqlGenerator - Introduce ISqlServerOptions, SqlServerOptions to flow SqlServerDbOptionsExtension to SqlServerQuerySqlGenerator as singleton service to get value of RowNumberPaging - Remove SqlServerQueryModelVisitor - Add explicit tests for #6736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-bug
Use Include with OrderBy with Skip(0) will cause OrderBy gets ignored.
Steps to reproduce
This is the standalone project for reproduce the problem
EFExample.zip
The main code is as follows
The output is
The issue
EF generated following SQL
Further technical details
EF Core version: 1.0.1
Operating system: Windows 8.1
Visual Studio version: VS2015 update 3
The text was updated successfully, but these errors were encountered: