Review provider breaking changes approach #6622
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-bug
Milestone
Comments
Closed
ajcvickers
added a commit
that referenced
this issue
Oct 7, 2016
Issue #6622 The approach we discussed didn't pan out exactly because IRelationalDatabaseCreator can also be obtained as the non-relational service IDatabaseCreator. The delegate for this is defined in the core package and so cannot directly reference relational types. Therefore, I created an abstract interface that any provider service can implement which then allows the service itself to request the additional services it needs. Tested by making SQLite and SQL Server providers use the obsolete constructor and running all tests. RelationalQueryContextFactory was not changed--see issue #6713. We should review other constructors for changes--see issue #6714
ajcvickers
added a commit
that referenced
this issue
Oct 7, 2016
Issue #6622 The approach we discussed didn't pan out exactly because IRelationalDatabaseCreator can also be obtained as the non-relational service IDatabaseCreator. The delegate for this is defined in the core package and so cannot directly reference relational types. Therefore, I created an abstract interface that any provider service can implement which then allows the service itself to request the additional services it needs. Tested by making SQLite and SQL Server providers use the obsolete constructor and running all tests. RelationalQueryContextFactory was not changed--see issue #6713. We should review other constructors for changes--see issue #6714
ajcvickers
added
the
closed-fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Connection resiliency introduced breaking changes to some of the base classes for provider services by requiring a new dependency in the constructor for
RelationalDatabaseCreatorandRelationalQueryContextFactory. We could use suboptimal workarounds to avoid this or we could introduce a dependency onICurrentDbContextin all of our provider services base classes, so it can be used to resolve the new dependencies without breaking existing implementations for future releases.The text was updated successfully, but these errors were encountered: