Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite Migrations: Autoincrement annotation not prefixed #6461

Closed
bricelam opened this issue Sep 2, 2016 · 1 comment
Closed

SQLite Migrations: Autoincrement annotation not prefixed #6461

bricelam opened this issue Sep 2, 2016 · 1 comment
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@bricelam
Copy link
Contributor

bricelam commented Sep 2, 2016

We currently generate the following for SQLite...

.Annotation("Autoincrement", true)

...and the following for SQL Server

.Annotation("SqlServer:ValueGenerationStrategy", SqlServerValueGenerationStrategy.IdentityColumn)

IMHO, the first one should be Sqlite:Autoincrement. Unfortunately, we RTMed like this so we'll always have to support just Autoincrement, but we can change what we scaffold by default.

@bricelam
Copy link
Contributor Author

bricelam commented Sep 2, 2016

Although MySQL also calls it AUTO_INCREMENT, so maybe it can just be a well-known, shared annotation.

@divega divega added this to the Backlog milestone Sep 2, 2016
@divega divega added the type-bug label Sep 2, 2016
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 6, 2016
@bricelam bricelam modified the milestones: 1.1.0-preview1, Backlog Oct 6, 2016
@bricelam bricelam changed the title SQLite Migrations: Should Autoincrement annotation be prefixed? SQLite Migrations: Autoincrement annotation not prefixed Oct 6, 2016
@ajcvickers ajcvickers modified the milestones: 1.1.0-preview1, 1.1.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

No branches or pull requests

3 participants